Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | "Update link in "Waiting for Confirmation" modal" | #212

Closed
wants to merge 1 commit into from
Closed

Fix | "Update link in "Waiting for Confirmation" modal" | #212

wants to merge 1 commit into from

Conversation

eben619
Copy link
Contributor

@eben619 eben619 commented Nov 5, 2024 •
edited
Loading

Description

Updated the link from https://gooddollar.notion.site/How-do-transactions-work-in-web3-ccf11b4e16874a1682722a20c4e24742 to https://docs.gooddollar.org/frequently-asked-questions/using-gooddollar#how-do-transactions-work-in-web3

About #211

How Has This Been Tested?

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

@eben619 eben619 marked this pull request as ready for review November 5, 2024 18:44
@sirpy sirpy closed this Nov 6, 2024
@scoutgamebot
Copy link

Scout Game Alert: ⚠️

It looks like this Pull Request was closed by the maintainer. As a result, you've received your first strike in the Scout Game. Your current strike count is 1.

Please note that if you reach 3 strikes, your account will be suspended from the Scout Game.

If you believe this was a mistake and wish to appeal now or after 3 strikes, you can submit an appeal at: https://app.charmverse.io/scout-game-appeal/scout-game-appeals-3853798695994546.

@sirpy sirpy reopened this Nov 6, 2024
@sirpy
Copy link
Contributor

sirpy commented Nov 6, 2024

@eben619 why does it says the head ref contains hidden characters?
image

@eben619
Copy link
Contributor Author

eben619 commented Nov 6, 2024

@sirpy I think I know why. Let me rectify it.

@eben619 eben619 closed this Nov 6, 2024
@eben619 eben619 deleted the fix/Update-link-in-"Waiting-for-Confirmation"-modal branch November 6, 2024 11:04
@eben619
Copy link
Contributor Author

eben619 commented Nov 6, 2024

This was the original head with special characters.

1730891256641

But it got hidden and formatted to this.

1730891274159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eben619 @scoutgamebot @sirpy